Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(headscale): removal of headscale #635

Merged
merged 2 commits into from
Oct 11, 2024
Merged

Conversation

IvoGoman
Copy link
Contributor

Description

Currently headscale is not used beeing deployed & used with Greenhouse.
To avoid unnecessary refactorings and time spend to validate Dependabot PRs
we decided to not touch the code for now.
This PR removes all usage of Headscale, so that we can revert when we have
a concrete usage for this in the future.

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

  • Related Issue # (issue)
  • Closes # (issue)
  • Fixes # (issue)

Remove if not applicable

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help
  • Separate ticket for tests # (issue/pr)

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Added to documentation?

  • 📜 README.md
  • 🤝 Documentation pages updated
  • 🙅 no documentation needed
  • (if applicable) generated OpenAPI docs for CRD changes

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Currently headscale is not used beeing deployed & used with Greenhouse.
To avoid unnecessary refactorings and time spend to validate Dependabot PRs
we decided to not touch the code for now.
This PR removes all usage of Headscale, so that we can revert when we have
a concrete usage for this in the future.
@IvoGoman IvoGoman requested review from a team as code owners October 10, 2024 11:43
@github-actions github-actions bot added documentation Improvements or additions to documentation core-apis helm-charts dependencies labels Oct 10, 2024
@IvoGoman IvoGoman merged commit 2a28dc7 into main Oct 11, 2024
@IvoGoman IvoGoman deleted the refac/remove-headscale branch October 11, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-apis dependencies documentation Improvements or additions to documentation helm-charts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants