Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REFAC] - Standardise TeamMembershipUpdaterController #582

Closed
4 tasks
Tracked by #544
IvoGoman opened this issue Sep 17, 2024 · 0 comments · Fixed by #684
Closed
4 tasks
Tracked by #544

[REFAC] - Standardise TeamMembershipUpdaterController #582

IvoGoman opened this issue Sep 17, 2024 · 0 comments · Fixed by #684
Assignees
@gciezkowski-acc

Comments

@IvoGoman
Copy link
Contributor

IvoGoman commented Sep 17, 2024 •
edited
Loading

As part of the standardisation of the reconciliation loop for Greenhouse controllers, this controller needs to be updated to follow the common recommendation for the Reconciliation

Only relevant for teammembership_updater_controller.go, skip teammembership_propagation_controller.go

Acceptance Criteria

  • Implement the Interface
  • Use the standardised patch for updating the status instead of the deferred update (if applicable)
  • Convert the tests to use test.TestSetup (if applicable) including creation of missing resources
  • Remove dedicated finalizers used on the controllers because they are replaced with standard ones.
@IvoGoman IvoGoman mentioned this issue Sep 17, 2024
Closed
9 tasks
@IvoGoman IvoGoman changed the title [FEAT] - Standardise TeamMembershipUpdaterController [REFAC] - Standardise TeamMembershipUpdaterController Sep 17, 2024
@github-project-automation github-project-automation bot moved this to Sprint Backlog in Greenhouse Core Roadmap Sep 17, 2024
gciezkowski-acc added a commit that referenced this issue Oct 29, 2024
@gciezkowski-acc
refac(teammembership) Standardization of Team Membership Updater (#582)
8c99e97
gciezkowski-acc added a commit that referenced this issue Oct 30, 2024
@gciezkowski-acc
refac(teammembership) Standardization of Team Membership Updater (#582)
698830a
@gciezkowski-acc gciezkowski-acc mentioned this issue Oct 30, 2024
Merged
26 tasks
gciezkowski-acc added a commit that referenced this issue Oct 30, 2024
@gciezkowski-acc
refac(teammembership) Standardization of Team Membership Updater (#582)
220601e
gciezkowski-acc added a commit that referenced this issue Oct 31, 2024
@gciezkowski-acc
refac(teammembership) Add comment to explain why status func is nil (#…
a8aadae 
…582)
@IvoGoman IvoGoman moved this from Sprint Backlog to In progress in Greenhouse Core Roadmap Oct 31, 2024
gciezkowski-acc added a commit that referenced this issue Nov 4, 2024
@gciezkowski-acc
refac(teammembership) Avoid infinite loop on delete (#582)
434f151
gciezkowski-acc added a commit that referenced this issue Nov 4, 2024
@gciezkowski-acc
refac(teammembership) Add status to team (#582)
3e4aa6a
gciezkowski-acc added a commit that referenced this issue Nov 5, 2024
@gciezkowski-acc
refac(teammembership) Add status to team (#582)
bb1db7a
gciezkowski-acc added a commit that referenced this issue Nov 5, 2024
@gciezkowski-acc
refac(teammembership) Standardization of Team Membership Updater (#582)
4cfe97b
gciezkowski-acc added a commit that referenced this issue Nov 5, 2024
@gciezkowski-acc
refac(teammembership) Standardization of Team Membership Updater (#582)
4dc21bc
gciezkowski-acc added a commit that referenced this issue Nov 5, 2024
@gciezkowski-acc
refac(teammembership) Add comment to explain why status func is nil (#…
4179b36 
…582)
gciezkowski-acc added a commit that referenced this issue Nov 5, 2024
@gciezkowski-acc
refac(teammembership) Avoid infinite loop on delete (#582)
6c7cdc3
gciezkowski-acc added a commit that referenced this issue Nov 5, 2024
@gciezkowski-acc
refac(teammembership) Add status to team (#582)
1369138
gciezkowski-acc added a commit that referenced this issue Nov 5, 2024
@gciezkowski-acc
refac(teammembership) Standardization of Team Membership Updater (#582)…
02cf60f 
… (#684)

* refac(teammembership) Standardization of Team Membership Updater (#582)

* Automatic generation of CRD API Docs

* refac(teammembership) Standardization of Team Membership Updater (#582)

* Automatic generation of CRD API Docs

* refac(teammembership) Add comment to explain why status func is nil (#582)

* refac(teammembership) Avoid infinite loop on delete (#582)

* Automatic generation of CRD API Docs

* refac(teammembership) Add status to team (#582)

* Automatic application of license header

* Automatic generation of CRD API Docs

* Automatic generation of CRD API Docs

---------

Co-authored-by: CRD API Docs Bot <crd_api_docs_bot@github.com>
Co-authored-by: License Bot <license_bot@github.com>
@github-project-automation github-project-automation bot moved this from In progress to Done in Greenhouse Core Roadmap Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gciezkowski-acc gciezkowski-acc

Labels
None yet
Projects
Greenhouse Core Roadmap
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refac(teammembership) Standardization of Team Membership Updater (#582) cloudoperators/greenhouse
2 participants
@IvoGoman @gciezkowski-acc