Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] - Persist helm diff to Plugin.Status #858

Open
5 tasks
uwe-mayer opened this issue Jan 21, 2025 · 0 comments
Open
5 tasks

[FEAT] - Persist helm diff to Plugin.Status #858

uwe-mayer opened this issue Jan 21, 2025 · 0 comments
Assignees
Labels

Comments

@uwe-mayer
Copy link
Contributor

Priority

None

User Story

As a Plugin admin I want to see the diff of a

  • Pluginversion update
  • Plugin configuration change

to currently deployed resources. No matter if deploying those changes failed or succeeded.

Description

We want to bubble up the diff that either

  • was deployed
  • failed to be deployed

up to the users.

The interface will be Plugin.Status.HelmReleaseStatus.Diff
The function to compute the diff is the existing diffObject function

Acceptance Criteria

  • New field Diff is added: Plugin.Status.HelmReleaseStatus.Diff
  • The upgradeRelease function sets the diff on the Plugin.Status no matter of the result of the upgrade. The diff is looked up in ctx and computed if not found there.
  • The existing diffObject function is reused.
  • Wherever the diff is already computed (above function is used) the diff is passed to ctx
  • Tests are in place for all Plugin changes scenarios

Reference Issues

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Todo
Development

No branches or pull requests

2 participants