generated from cloudoperators/repository-template
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(reconciler): Shared reconciliation loop logic for controllers #623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reconcile context stores the original resource that is being reconciled intact to patch status at a later point in time.
helper methods to add, remove finalizers to check and set status conditions
common reconcile interface to standardize reconciliation for all greenhouse controllers
…into feat/reconcile_standardization
…into feat/reconcile_standardization
IvoGoman
requested changes
Oct 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good and will make the controllers more readable/ better to maintain, also for new ones.
implements a strategy to update the status of the resource with conditions at a later point in time
re-write tests to ginkgo
…loudoperators/greenhouse into feat/reconcile_standardization
…loudoperators/greenhouse into feat/reconcile_standardization
26 tasks
ibakshay
reviewed
Oct 15, 2024
ibakshay
reviewed
Oct 15, 2024
Co-authored-by: Akshay Iyyadurai Balasundaram <akshay.iyyadurai.balasundaram@sap.com>
IvoGoman
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements a shared
Reconcile
functionality that can be adopted by all controllers to have standard base reconciliation loop.greenhouse.sap/cleanup
and removes the need for individual finalizers for each resourceEnsureCreated
andEnsureDeleted
WithEventFilter
to avoid duplicate reconciliationReconcile
What type of PR is this? (check all applicable)
Related Tickets & Documents
Added tests?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Added to documentation?
Checklist