generated from cloudoperators/repository-template
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dex): dex backend storage adapter implementation #839
Open
kengou
wants to merge
54
commits into
main
Choose a base branch
from
feat/dex-sql
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,970
−259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IvoGoman
reviewed
Jan 15, 2025
additionally while creating OAuth2Client in postgres it also generates client secret in the organization namespace
additionally while creating OAuth2Client in postgres it also generates client secret in the organization namespace
removes dependency to dex CRDs if the storage backend is postgres
@IvoGoman @kengou - Please review from scratch as the implementation has been re-written Implements:
Additionally implements #798 -
TODO -
|
automatically determines the kubernetes client mode without explicitly specifying any env variable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements:
dex
storage selection from aConfigMap
Dex
backend storage adapter interface to supportkubernetes
orpostgres
idproxy
andOrganization Reconciler
uses the storage adapter interfaceAdditionally implements #798 partially -
kubernetes
then Dex Custom Resources are created in the organization's namespaceWhat type of PR is this? (check all applicable)
Related Tickets & Documents
Added tests?
Added to documentation?
Checklist