Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ApiModule can be vendored in the pytest package #135

Merged
merged 1 commit into from
Nov 16, 2017

Conversation

ogrisel
Copy link
Contributor

@ogrisel ogrisel commented Nov 16, 2017

test_dynamic_pytest_module would fail with a recent upgrade of the py.test project.

@codecov-io
Copy link

codecov-io commented Nov 16, 2017

Codecov Report

Merging #135 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #135   +/-   ##
=======================================
  Coverage   83.76%   83.76%           
=======================================
  Files           2        2           
  Lines         536      536           
  Branches       98       98           
=======================================
  Hits          449      449           
  Misses         64       64           
  Partials       23       23

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa4b1ce...c202ebd. Read the comment docs.

@ogrisel
Copy link
Contributor Author

ogrisel commented Nov 16, 2017

@rgbkrk I am merging this quick fix that would otherwise break the CI of all other incoming PR for no good reason :)

@ogrisel ogrisel merged commit ce7f1b5 into cloudpipe:master Nov 16, 2017
@ogrisel ogrisel deleted the fix-test_dynamic_pytest_module branch November 16, 2017 15:23
@rgbkrk
Copy link
Member

rgbkrk commented Nov 16, 2017

Great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants