Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #129: do not silence RuntimeError in dump() #140

Merged
merged 1 commit into from
Dec 13, 2017

Conversation

pitrou
Copy link
Member

@pitrou pitrou commented Dec 13, 2017

No description provided.

@codecov-io
Copy link

codecov-io commented Dec 13, 2017

Codecov Report

Merging #140 into master will decrease coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #140      +/-   ##
==========================================
- Coverage   83.85%   83.79%   -0.07%     
==========================================
  Files           2        1       -1     
  Lines         539      537       -2     
  Branches       98       98              
==========================================
- Hits          452      450       -2     
+ Misses         64       63       -1     
- Partials       23       24       +1
Impacted Files Coverage Δ
cloudpickle/cloudpickle.py 83.79% <100%> (+0.03%) ⬆️
cloudpickle/__init__.py

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abeb3fb...a62d920. Read the comment docs.

@ogrisel
Copy link
Contributor

ogrisel commented Dec 13, 2017

LGTM!

@ogrisel ogrisel merged commit 0c1fde1 into cloudpipe:master Dec 13, 2017
@pitrou pitrou deleted the reraise_pickle_exceptions branch December 13, 2017 15:41
BryanCutler added a commit to BryanCutler/spark that referenced this pull request Jan 31, 2018
HyukjinKwon pushed a commit to HyukjinKwon/cloudpickle that referenced this pull request Feb 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants