Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #211
This PR fix the way we detect that a module is importable for local functions.
Note that this not completly fixes the problem in #211 as the issue still appears for dynamic modules eg if you change
tests/cloudpickle_test.py
from line 419 tothen the output of the test is
But I don't think it is possible to fix that as it probably has to do with internal dealing of python for creating a
FunctionType
object .