-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dont pickle abc caches of instances of abc.ABCMeta subclasses. #303
Conversation
@llllllllll if you want to take a look. |
Codecov Report
@@ Coverage Diff @@
## master #303 +/- ##
===========================================
- Coverage 92.84% 78.86% -13.98%
===========================================
Files 2 2
Lines 852 861 +9
Branches 177 178 +1
===========================================
- Hits 791 679 -112
- Misses 37 143 +106
- Partials 24 39 +15
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #303 +/- ##
======================================
Coverage 92.9% 92.9%
======================================
Files 2 2
Lines 860 860
Branches 179 179
======================================
Hits 799 799
Misses 37 37
Partials 24 24 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Maybe @pitrou wants to have a look as I think he originally contributed the 3.7+ code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but the changelog need an update.
Closes #302
Don't pickle the
abc
caches populated duringisinstance
/issubclass
checks against instances ofabc.ABCMeta
subclasses.