Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

filter out ap-northeast-3 region #33

Merged
merged 6 commits into from
Mar 4, 2021
Merged

filter out ap-northeast-3 region #33

merged 6 commits into from
Mar 4, 2021

Conversation

mcalhoun
Copy link
Collaborator

@mcalhoun mcalhoun commented Mar 4, 2021

what

  • Exclude ap-northeast-3 region from the enabled regions API call
  • Remove some redundant type specifications
  • Update the docs to be more clear on what is deleted when VPCs are deleted

why

  • The AWS SDK for Go currently doesn't generate endpoints for the ap-northeast-3 region and an issue has been opened to track this.

@mcalhoun mcalhoun merged commit f32541c into master Mar 4, 2021
@mcalhoun mcalhoun deleted the chore/filter-ap-northeast-3 branch March 4, 2021 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@osterman osterman osterman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mcalhoun @osterman