Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in example #19

Merged
merged 3 commits into from
Sep 5, 2023

Conversation

vanastassiou
Copy link
Contributor

what

  • Fixes typo in example module syntax

why

  • Consistent spelling is good

references

  • n/a

@vanastassiou vanastassiou requested review from a team as code owners August 3, 2022 20:50
@vanastassiou vanastassiou force-pushed the chore/fix-typo-in-readme branch from e1878ff to f91ea64 Compare August 3, 2022 21:29
@vanastassiou
Copy link
Contributor Author

@dotCipher @RothAndrew -- any thoughts on this one?

README.md Show resolved Hide resolved
@vanastassiou vanastassiou force-pushed the chore/fix-typo-in-readme branch from eab80d9 to 86d77e3 Compare August 30, 2022 16:33
@RothAndrew
Copy link

/test all

@RothAndrew RothAndrew enabled auto-merge (squash) August 30, 2022 16:37
@RothAndrew
Copy link

derp. guess I'm not a codeowner. Summoning @cloudposse/engineering or @cloudposse/approvers

@vanastassiou
Copy link
Contributor Author

Just getting back to this one since I see it still open... @RothAndrew I'm not sure your tag worked, unfortunately.

jamengual
jamengual previously approved these changes Aug 28, 2023
@jamengual
Copy link
Contributor

/tests all

@vanastassiou
Copy link
Contributor Author

@jamengual any idea what has that last test taking so long? I wonder if it's reasonable to skip certain tests if only Markdown files are updated...

@jamengual
Copy link
Contributor

jamengual commented Aug 30, 2023

could you run make precommit/terraform and commit all changes?
then I believe we will need Code owners review from someone in CloudPosse @max-lobur

@jamengual
Copy link
Contributor

/terratest

aknysh
aknysh previously approved these changes Sep 1, 2023
@jamengual jamengual dismissed stale reviews from aknysh and themself via b3a8278 September 2, 2023 01:17
@max-lobur max-lobur added no-release Do not create a new release (wait for additional code changes) minor New features that do not break anything and removed no-release Do not create a new release (wait for additional code changes) labels Sep 4, 2023
@max-lobur
Copy link
Contributor

/terratest

@RothAndrew RothAndrew merged commit 55dce83 into cloudposse:main Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor New features that do not break anything
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants