Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to set AWS ARN for S3 bucket policies #22

Merged
merged 5 commits into from
Jul 2, 2020
Merged

Allow to set AWS ARN for S3 bucket policies #22

merged 5 commits into from
Jul 2, 2020

Conversation

dlundgren
Copy link
Contributor

@dlundgren dlundgren commented Jun 11, 2020 •
edited
Loading

what

  • Allows the AWS ARN to be changed so that the module can be run in GovCloud.

why

  • Received the following error when attempting to deploy to GovCloud
    Error: Error putting S3 policy: MalformedPolicy: Policy has invalid resource

references

@jamengual
Copy link
Contributor

/rebuild-readme

@dlundgren dlundgren requested a review from a team as a code owner July 2, 2020 07:04
@jamengual
Copy link
Contributor

/test all

@jamengual
Copy link
Contributor

@dlundgren could you resolve the conflicts, please ?

jamengual
jamengual previously approved these changes Jul 2, 2020
View reviewed changes
jamengual
jamengual previously approved these changes Jul 2, 2020
View reviewed changes
@jamengual
Copy link
Contributor

/test all

@jamengual
Copy link
Contributor

/rebuild-readme

@jamengual
Copy link
Contributor

/test all

@jamengual jamengual merged commit 2d303e9 into cloudposse:master Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamengual jamengual jamengual approved these changes

@nitrocode nitrocode Awaiting requested review from nitrocode

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dlundgren @jamengual @actions-bot