Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: updating GitHub token to be stored as a secret #90

Merged
merged 2 commits into from
Aug 5, 2021
Merged

fix: updating GitHub token to be stored as a secret #90

merged 2 commits into from
Aug 5, 2021

Conversation

gausnes
Copy link
Contributor

@gausnes gausnes commented Jul 6, 2021

what

  • updating GitHub token to be stored as a secret, it's currently being stored as plaintext

why

  • reducing attack surface area for leaking provisioned tokens

@gausnes gausnes requested review from a team as code owners July 6, 2021 20:25
@gausnes gausnes requested review from srhopkins and SweetOps and removed request for a team July 6, 2021 20:26
@gausnes gausnes changed the title fix: updating git token to be stored as a secret fix: updating GitHub token to be stored as a secret Jul 6, 2021
nitrocode
nitrocode reviewed Aug 2, 2021
View reviewed changes
main.tf Outdated Show resolved Hide resolved
nitrocode
nitrocode reviewed Aug 3, 2021
View reviewed changes
variables.tf Outdated Show resolved Hide resolved
@nitrocode
Copy link
Member

/test all

@nitrocode nitrocode merged commit d078282 into cloudposse:master Aug 5, 2021
@nitrocode
Copy link
Member

This has been released as https://github.com/cloudposse/terraform-aws-codebuild/releases/tag/0.37.0

Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nitrocode nitrocode nitrocode approved these changes

@srhopkins srhopkins Awaiting requested review from srhopkins

@SweetOps SweetOps Awaiting requested review from SweetOps

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gausnes @nitrocode @cloudpossebot