Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make use of S3 bucket ownership #18

Merged
merged 4 commits into from
Oct 29, 2021
Merged

Make use of S3 bucket ownership #18

merged 4 commits into from
Oct 29, 2021

Conversation

max-lobur
Copy link
Contributor

@max-lobur max-lobur requested review from a team as code owners October 13, 2021 14:14
@max-lobur max-lobur requested a review from a team as a code owner October 13, 2021 14:15
@max-lobur
Copy link
Contributor Author

/test all

nitrocode
nitrocode previously approved these changes Oct 29, 2021
View reviewed changes
@nitrocode
Copy link
Member

can you bump provider aws to 3.x and remove any unused providers? might as well since this is such a small change

@nitrocode
Copy link
Member

@max-lobur looks like tests failed here

@max-lobur
Copy link
Contributor Author

yeah the module was non-existent

@max-lobur
Copy link
Contributor Author

/test all

@max-lobur max-lobur merged commit 9340d09 into master Oct 29, 2021
@max-lobur max-lobur deleted the ownership branch October 29, 2021 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nitrocode nitrocode nitrocode approved these changes

@Makeshift Makeshift Awaiting requested review from Makeshift Makeshift was automatically assigned from cloudposse/contributors

@RothAndrew RothAndrew Awaiting requested review from RothAndrew RothAndrew was automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@max-lobur @nitrocode @cloudpossebot