Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make allowed CIDR blocks a variable #12

Merged
merged 2 commits into from
Oct 17, 2018
Merged

Make allowed CIDR blocks a variable #12

merged 2 commits into from
Oct 17, 2018

Conversation

oavdeev-hs
Copy link
Contributor

Why

Bastion doesn't have to be available from any IP (0.0.0.0/0).

What

Add a parameter to configure allowed IP ranges.

@osterman osterman requested a review from aknysh October 17, 2018 01:12
@osterman osterman added the enhancement New feature or request label Oct 17, 2018
osterman
osterman previously approved these changes Oct 17, 2018
variable "allowed_cidr_blocks" {
type = "list"
description = "A list of CIDR blocks allowed to connect"
default = [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please run terraform fmt

Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments
thanks again @oavdeev-hs

@oavdeev-hs
Copy link
Contributor Author

Fixed! thanks for quick response on these

@aknysh aknysh merged commit 309ab85 into cloudposse:master Oct 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants