Remove deprecated argument "vpc"

[yuekui]

what

Remove the deprecated vpc argument to fix the warning. The vpc parameter has been deprecated since the AWS provider version 5.0, there's no need to explicitly specify either vpc or domain. Simply omitting it and using the default value will ensure optimal compatibility.

references

https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/eip#vpc

[nitrocode]

/terratest

[nitrocode]

I'm unsure on the correct fix in the lint step and the codeowners seems different than other repos which leads me to believe that the repo is a little out of date. I reached out in the sweetops slack channel for assistance by an @cloudposse/admins and @cloudposse/approvers .

https://sweetops.slack.com/archives/CUJPCP1K6/p1715088607211699

[osterman]

/terratest

[nitrocode]

@osterman pr 232 should fix the test in this pr

#232

[osterman]

/terratest

[nitrocode]

Still seems like the linter is failing @osterman. Terratest passes tho

[osterman]

@goruha can you check what is going on?

[Nuru]

@osterman @goruha As I said before, adding issues: write (#231) does not fix the problem of the actions not being able to post comments on the PRs.

@yuekui @nitrocode The linter is failing because it is applying new standards to old code. Nothing in the PR is wrong, but despite that, syntax in the Terraform code (in the module or the examples) like

join("", aws_instance.default.*.id)

is no longer allowed. You need to globally replace .*. with [*]..

[yuekui]

@yuekui @nitrocode The linter is failing because it is applying new standards to old code. Nothing in the PR is wrong, but despite that, syntax in the Terraform code (in the module or the examples) like

join("", aws_instance.default.*.id)

is no longer allowed. You need to globally replace .*. with [*]..

Got it, I could fix that, thanks!

[mergify]

💥 This pull request now has conflicts. Could you fix it @yuekui? 🙏

[mergify]

This pull request was automatically closed as it no longer contains any changes.

This typically happens when another merged pull request has already included this request's
proposed modifications into the default branch.

[mergify]

This pull request was automatically closed as it no longer contains any changes.

This typically happens when another merged pull request has already included this request's
proposed modifications into the default branch.

[Nuru]

/terratest