Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Run make github/init, Allow for context.tf That Has null-label:0.25.0 #94

Merged
merged 3 commits into from
Jan 5, 2022

Conversation

korenyoni
Copy link
Member

what

  • Run make github/init.
  • Bump security-group module to minimum version with context.tf that has null-label:0.25.0.
  • Bump route53-cluster-hostname module to latest.

why

  • Running make github/init updates GHA-related files, including those relating to release-drafter which will now allow a no-release label that can be used to consolidate multiple PRs into a single release.
  • Allow for a context.tf that has null-label:0.25.0 to be used with this module, without having to introduce changes allowing for https://github.com/cloudposse/terraform-aws-security-group 0.4.0+ (out of scope for this PR).

references

…s null-label:0.25.0; bump route53-cluster-hostname module to latest.
@korenyoni korenyoni requested review from a team as code owners January 5, 2022 21:48
@korenyoni korenyoni added bug 🐛 An issue with the system patch A minor, backward compatible change labels Jan 5, 2022
@korenyoni
Copy link
Member Author

/test all

@korenyoni korenyoni requested a review from aknysh January 5, 2022 21:52
@korenyoni korenyoni merged commit d2fa23a into master Jan 5, 2022
@korenyoni korenyoni deleted the fix/misc-fixes branch January 5, 2022 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 An issue with the system patch A minor, backward compatible change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants