feat: replace template provider with templatefile function
#95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![bridgecrew[bot]](https://avatars.githubusercontent.com/in/52968?s=60&v=4){kind=small}
| ssh_user = var.ssh_user | ||
| } | ||
| } | ||
|
|
||
| resource "aws_instance" "default" { |
There was a problem hiding this comment.
Suggested change
| resource "aws_instance" "default" { | |
| resource "aws_instance" "default" { | |
| ebs_optimized = true |
Ensure that EC2 is EBS optimized
Resource: aws_instance.default | ID: BC_AWS_GENERAL_68
Description
TBA| ssh_user = var.ssh_user | ||
| } | ||
| } | ||
|
|
||
| resource "aws_instance" "default" { |
There was a problem hiding this comment.
Ensure EBS volumes have encrypted launch configurations
Resource: aws_instance.default | ID: BC_AWS_GENERAL_13
How to Fix
resource "aws_launch_configuration" "example" {
...
instance_type = "t2.micro"
+ root_block_device {
+ encrypted = true
+ }
...
}Description
Amazon Elastic Block Store (EBS) volumes allow you to create encrypted launch configurations when creating EC2 instances and auto scaling. When the entire EBS volume is encrypted, data stored at rest on the volume, disk I/O, snapshots created from the volume, and data in-transit between EBS and EC2 are all encrypted.Benchmarks
- PCI-DSS V3.2 3
| ssh_user = var.ssh_user | ||
| } | ||
| } | ||
|
|
||
| resource "aws_instance" "default" { |
There was a problem hiding this comment.
Suggested change
| resource "aws_instance" "default" { | |
| resource "aws_instance" "default" { | |
| ebs_optimized = true |
Ensure that EC2 is EBS optimized
Resource: module.ec2_bastion.aws_instance.default | ID: BC_AWS_GENERAL_68
Description
TBA
| ssh_user = var.ssh_user | ||
| } | ||
| } | ||
|
|
||
| resource "aws_instance" "default" { |
There was a problem hiding this comment.
Ensure EBS volumes have encrypted launch configurations
Resource: aws_instance.default | ID: BC_AWS_GENERAL_13
How to Fix
resource "aws_launch_configuration" "example" {
...
instance_type = "t2.micro"
+ root_block_device {
+ encrypted = true
+ }
...
}Description
Amazon Elastic Block Store (EBS) volumes allow you to create encrypted launch configurations when creating EC2 instances and auto scaling. When the entire EBS volume is encrypted, data stored at rest on the volume, disk I/O, snapshots created from the volume, and data in-transit between EBS and EC2 are all encrypted.Benchmarks
- PCI-DSS V3.2 3
Calculating...
| ssh_user = var.ssh_user | ||
| } | ||
| } | ||
|
|
||
| resource "aws_instance" "default" { |
There was a problem hiding this comment.
Suggested change
| resource "aws_instance" "default" { | |
| resource "aws_instance" "default" { | |
| ebs_optimized = true |
Ensure that EC2 is EBS optimized
Resource: aws_instance.default | ID: BC_AWS_GENERAL_68
Description
TBADependent Resources
Calculating...
There was a problem hiding this comment.
Change details
-
Error ID Change Path Resource BC_AWS_GENERAL_13 Added /main.tf aws_instance.default BC_AWS_GENERAL_68 Added /main.tf aws_instance.default
…rm-aws-ec2-bastion-server into remove_template_provider
| ssh_user = var.ssh_user | ||
| } | ||
| } | ||
|
|
||
| resource "aws_instance" "default" { |
There was a problem hiding this comment.
Suggested change
| resource "aws_instance" "default" { | |
| resource "aws_instance" "default" { | |
| ebs_optimized = true |
Ensure that EC2 is EBS optimized
Resource: aws_instance.default | ID: BC_AWS_GENERAL_68
Description
TBADependent Resources
Calculating...
| ssh_user = var.ssh_user | ||
| } | ||
| } | ||
|
|
||
| resource "aws_instance" "default" { |
There was a problem hiding this comment.
Ensure EBS volumes have encrypted launch configurations
Resource: aws_instance.default | ID: BC_AWS_GENERAL_13
How to Fix
resource "aws_launch_configuration" "example" {
...
instance_type = "t2.micro"
+ root_block_device {
+ encrypted = true
+ }
...
}Description
Amazon Elastic Block Store (EBS) volumes allow you to create encrypted launch configurations when creating EC2 instances and auto scaling. When the entire EBS volume is encrypted, data stored at rest on the volume, disk I/O, snapshots created from the volume, and data in-transit between EBS and EC2 are all encrypted.Benchmarks
- PCI-DSS V3.2 3
Calculating...
There was a problem hiding this comment.
Change details
-
Error ID Change Path Resource BC_AWS_GENERAL_13 Added /main.tf aws_instance.default BC_AWS_GENERAL_68 Added /main.tf aws_instance.default
| ssh_user = var.ssh_user | ||
| } | ||
| } | ||
|
|
||
| resource "aws_instance" "default" { |
There was a problem hiding this comment.
Ensure EBS volumes have encrypted launch configurations
Resource: aws_instance.default | ID: BC_AWS_GENERAL_13
How to Fix
resource "aws_launch_configuration" "example" {
...
instance_type = "t2.micro"
+ root_block_device {
+ encrypted = true
+ }
...
}Description
Amazon Elastic Block Store (EBS) volumes allow you to create encrypted launch configurations when creating EC2 instances and auto scaling. When the entire EBS volume is encrypted, data stored at rest on the volume, disk I/O, snapshots created from the volume, and data in-transit between EBS and EC2 are all encrypted.Benchmarks
- PCI-DSS V3.2 3
Calculating...
| ssh_user = var.ssh_user | ||
| } | ||
| } | ||
|
|
||
| resource "aws_instance" "default" { |
There was a problem hiding this comment.
Suggested change
| resource "aws_instance" "default" { | |
| resource "aws_instance" "default" { | |
| ebs_optimized = true |
Ensure that EC2 is EBS optimized
Resource: aws_instance.default | ID: BC_AWS_GENERAL_68
Description
TBADependent Resources
Calculating...
There was a problem hiding this comment.
Change details
-
Error ID Change Path Resource BC_AWS_GENERAL_13 Added /main.tf aws_instance.default BC_AWS_GENERAL_68 Added /main.tf aws_instance.default
|
/test all |
Gowiem
approved these changes
Feb 17, 2022
Gowiem
changed the title
template provider with templatefile function
|
@kevcube Thanks for the contribution! Released as https://github.com/cloudposse/terraform-aws-ec2-bastion-server/releases/tag/0.30.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
why
Duplicate
#91
I didn't realize until after pushing 🤦