Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating context and SG module version 4 #153

Closed
wants to merge 12 commits into from
Closed

Updating context and SG module version 4 #153

wants to merge 12 commits into from

Conversation

jamengual
Copy link
Contributor

what

  • Update context to latest version
  • Update security group module to release 4.0

why

  • to provide new SG 4.x functionality and updates

references

@jamengual jamengual requested a review from a team as a code owner December 22, 2021 05:20
@jamengual
Copy link
Contributor Author

/test all

@jamengual jamengual requested a review from a team as a code owner December 22, 2021 05:21
@jamengual jamengual requested review from dotCipher and max-lobur and removed request for a team December 22, 2021 05:21
@nitrocode nitrocode requested a review from Nuru December 22, 2021 05:26
@nitrocode
Copy link
Member

Thanks for the contribution Pepe.

In order to migrate, the following will need to be done

  1. Review other past PRs
  2. Deprecate old variables instead of removing them
  3. Make sure tests work
  4. Deploy the existing non-pre-release version of this module
  5. Migrate that version to this PR's version
  6. Create a migration doc
  7. Merge branches of existing open PRs (if they look OK)
  8. Tag existing PRs in this PR
  9. Go back up to "Make sure tests work"
  10. Ping @Nuru for a review
  11. Address changes and go back to "Make sure tests work"

In order to revert, the following will need to be done

  1. Go back to the pre-release version
  2. Start above from step 7

@jamengual
Copy link
Contributor Author

/test all

@jamengual jamengual requested a review from a team as a code owner December 22, 2021 06:02
@jamengual
Copy link
Contributor Author

/test all

@jamengual
Copy link
Contributor Author

/test all

@jamengual
Copy link
Contributor Author

/test all

@jamengual
Copy link
Contributor Author

/test all

@jamengual
Copy link
Contributor Author

/test all

@jamengual
Copy link
Contributor Author

/test all

@mergify
Copy link

mergify bot commented Dec 27, 2021

This pull request is now in conflict. Could you fix it @jamengual? 🙏

@hans-d hans-d closed this Mar 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotCipher dotCipher Awaiting requested review from dotCipher dotCipher is a code owner automatically assigned from cloudposse/contributors

@max-lobur max-lobur Awaiting requested review from max-lobur max-lobur is a code owner automatically assigned from cloudposse/contributors

@Nuru Nuru Awaiting requested review from Nuru

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jamengual @nitrocode @hans-d @cloudpossebot