Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor module to support autoscaling #4

Merged
merged 3 commits into from
Jul 16, 2018
Merged

Conversation

sarkis
Copy link
Contributor

@sarkis sarkis commented Jul 6, 2018

what

Refactor module to support autoscaling.

why

DRY - eliminates need to duplicate the same Alarms in a different module.

@sarkis sarkis requested a review from osterman July 6, 2018 17:11
Copy link
Member

@osterman osterman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful! Great consistency on variable names. Perfect use of label attributes.

@sarkis
Copy link
Contributor Author

sarkis commented Jul 6, 2018

@osterman SweetOps at it's finest :bowtie:

@sarkis sarkis merged commit e890a95 into master Jul 16, 2018
@sarkis sarkis deleted the refactor-for-autoscaling branch July 16, 2018 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants