Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing volume_type (volume_ typo) in block_device_mappings #6

Closed
zaksamalik opened this issue Nov 28, 2022 · 1 comment · Fixed by #11
Closed

missing volume_type (volume_ typo) in block_device_mappings #6

zaksamalik opened this issue Nov 28, 2022 · 1 comment · Fixed by #11
Labels
bug 🐛 An issue with the system

Comments

@zaksamalik
Copy link

Found a bug? Maybe our Slack Community can help.

Slack Community

Describe the Bug

volume_type is missing from block_device_mappings. Assuming typo is volume_ input. Also missing throughput input. Will put up PR with updated code once cloudposse/terraform-aws-ec2-autoscale-group#97 is merged using the new version tag. The referenced PR adds throughput input to the autoscale group.

Expected Behavior

A clear and concise description of what you expected to happen.

Steps to Reproduce

Steps to reproduce the behavior:

  1. Go to '...'
  2. Run '....'
  3. Enter '....'
  4. See error

Screenshots

If applicable, add screenshots or logs to help explain your problem.

Environment (please complete the following information):

Anything that will help us triage the bug will help. Here are some ideas:

  • OS: [e.g. Linux, OSX, WSL, etc]
  • Version [e.g. 10.15]

Additional Context

Add any other context about the problem here.

@zaksamalik zaksamalik added the bug 🐛 An issue with the system label Nov 28, 2022
@zaksamalik zaksamalik changed the title volume_ type in block_device_mappings missing volume_type (volume_ typo) in block_device_mappings Nov 28, 2022
@esolitos
Copy link
Contributor

esolitos commented Mar 2, 2023

It seems that a wild sed command was issued, because I ca see the same problem with:

  • instance_market_options lists market_ but should be => market_type
  • instance_market_options lists spot_instance_ but should be => spot_instance_type

I'll open a PR for this. :)

esolitos added a commit to esolitos/terraform-aws-ecs-cluster that referenced this issue Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 An issue with the system
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants