chore(deps): update terraform cloudposse/ec2-autoscale-group/aws to v0.35.0 (main) #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![renovate[bot]](https://avatars.githubusercontent.com/in/2740?s=60&v=4){kind=small}
renovate
bot
force-pushed
the
renovate/main-cloudposse-ec2-autoscale-group-aws-0.x
branch
from
e4c4a2c
to
2561c61
Compare
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. ⚠ Warning: custom changes will be lost. |
max-lobur
approved these changes
Jul 6, 2023
|
/terratest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
0.34.2->0.35.0Release Notes
cloudposse/terraform-aws-ec2-autoscale-group (cloudposse/ec2-autoscale-group/aws)
v0.35.0Compare Source
Made spot_options in instance_market_options optional @skjensen (#117)
what
Made spot_options in instance_market_options optional.
why
On the AWS Web console there is an option to tick a box that provides guidance on how to create a Launch Template, there works with an EC2 Auto scaling group.
Expanding the "Advanced details" ticking "Request spot instance" you will see most of the options are marked as "Don't include in launch template (recommended)"
Expiry date and Interruption behaviour are not applicable. Having all spot_options as required in this template makes it impossible to enable spot instances in an EC2 Auto Scaling group.
On a related note, but not requiring any change to the module.
The variable
instance_initiated_shutdown_behaviorshould be set to null as it's also not allowed in the Launch Template when used for an EC2 Auto Scaling groupreferences
https://docs.aws.amazon.com/autoscaling/ec2/userguide/create-launch-template.html
Support AWS Provider V5 @max-lobur (#116)
what
Support AWS Provider V5
Linter fixes
why
Maintenance
references
https://github.com/hashicorp/terraform-provider-aws/releases/tag/v5.0.0
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate. View repository job log here.