Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ECS Cluster default Service Discovery Namespace support #29

Merged
merged 5 commits into from
Mar 20, 2024
Merged

ECS Cluster default Service Discovery Namespace support #29

merged 5 commits into from
Mar 20, 2024

Conversation

Benbentwo
Copy link
Member

what

  • add support for default service discovery namespace

why

  • service discovery acts as a local DNS for all your ECS Services, it is often useful to have an entire cluster of services capable of speaking with one another.

references:

@Benbentwo Benbentwo requested review from a team as code owners March 20, 2024 16:19
github-actions[bot]
github-actions bot reviewed Mar 20, 2024
View reviewed changes
variables.tf Outdated Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
@mergify mergify bot added the triage Needs triage label Mar 20, 2024
Benbentwo and others added 2 commits March 20, 2024 09:20
@Benbentwo
Merge branch 'main' into feature/service_discovery_arn
ef1c67d
@Benbentwo @github-actions
Apply suggestions from code review
128a66a 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
korenyoni
korenyoni previously approved these changes Mar 20, 2024
View reviewed changes
Copy link
Member

@korenyoni korenyoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot added triage Needs triage and removed triage Needs triage labels Mar 20, 2024
@mergify mergify bot added triage Needs triage and removed triage Needs triage labels Mar 20, 2024
@Benbentwo
Update README and frontend to support default service discovery names…
b47523b 
…pace

This change updates the description and explanation of the infrastructure, including replacing some sections with modern equivalents. Additionally, it modifies frontend code to include support for default service discovery namespace. This will enhance flexible operations within AWS ECS cluster, ensuring smoother service discovery processes within the cloud environment.
@mergify mergify bot added triage Needs triage and removed triage Needs triage labels Mar 20, 2024
@Benbentwo
Copy link
Member Author

/terratest

@mergify mergify bot added triage Needs triage and removed triage Needs triage labels Mar 20, 2024
@Benbentwo Benbentwo merged commit 15d42de into main Mar 20, 2024
75 of 93 checks passed
@mergify mergify bot added the triage Needs triage label Mar 20, 2024
@Benbentwo Benbentwo deleted the feature/service_discovery_arn branch March 20, 2024 17:10
@mergify mergify bot removed the triage Needs triage label Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@korenyoni korenyoni korenyoni approved these changes

@nitrocode nitrocode Awaiting requested review from nitrocode nitrocode is a code owner automatically assigned from cloudposse/contributors

@gberenice gberenice Awaiting requested review from gberenice gberenice is a code owner automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Benbentwo @korenyoni