Support "override" property of EC2 autoscale groups #57
+26
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tell me if I should remove the ec2-autoscale-group version bump because I can see that there's already a PR for that, though it hasn't been pulled for a month. These changes were tested on live infra and are working as they should (well, I'm just exposing already available functionality). |
Lawstorant
force-pushed
the
support-override
branch
from
573735c
to
cf2e793
Compare
|
/terratest |
kevcube
approved these changes
Oct 8, 2024
kevcube
added
minor
|
I don't think I can fix the issue with the opentofu test |
|
@kevcube cen we run the test again? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
This enables the use of "override" property for mixed instances where one autoscale group can have multiple instance types, to avoid issues with unfillable spot requests. This is already supported in the "cloudposse/ec2-autoscale-group/aws" module.
why
To expose the functionality of the underlying module and make ECS infra configuration more resilient,
references
https://docs.aws.amazon.com/autoscaling/ec2/APIReference/API_LaunchTemplateOverrides.html
https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/autoscaling_group.html#mixed_instances_policy-1
https://github.com/cloudposse/terraform-aws-ec2-autoscale-group/tree/main?tab=readme-ov-file#input_mixed_instances_policy