fix: strengthen types, simplify logic (#154) #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: strengthen types, simplify logic * enable & use optional attrs * strengthen types for log_configuration, repository_credentials, system_controls, container_definition * rm redundant lookups * simplify secret & environment var sorting * Auto Format * fix: address missing optional; update examples/complete * Auto Format --------- Co-authored-by: cloudpossebot <11232728+cloudpossebot@users.noreply.github.com> Co-authored-by: Igor Rodionov <goruha@gmail.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
/terratest |
|
/terratest |
|
/terratest |
|
/terratest |
|
/terratest |
|
/terratest |
|
/terratest |
|
/terratest |
|
/terratest |
Benbentwo
previously approved these changes
Jun 8, 2023
aknysh
reviewed
Jun 9, 2023
aknysh
reviewed
Jun 9, 2023
Co-authored-by: Andriy Knysh <aknysh@users.noreply.github.com>
|
/terratest |
aknysh
approved these changes
Jun 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
log_configuration,repository_credentials,system_controls,container_definitionjsonencode/jsondecodecyclewhy
optionalobviateslookup(..., null)calls for objectslookup(o, k)without adefaultis deprecated in favor ofo[k]or direct attr access (o.k)log_configuration,repository_credentials, andsystem_controlshad needlessly opaqueanytypes which hinder DX and make subtle bugs more likely (e.g. in the types oflog_configuration.optionsvalues)container_definitionare now typed there's no reason not to type it as welllog_configurationappropriately obviates explicittostring&nullhandling; resolves Log Configuration Options should be options #151for-expressions iterate over maps & objects by key in lexicographic orderjsonencode-ing the final container definition only tojsondecodeforjson_map_objectis redundantRefs