Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add volumes_from and links #25

Merged
merged 2 commits into from
Mar 29, 2019
Merged

Add volumes_from and links #25

merged 2 commits into from
Mar 29, 2019

Conversation

charlieparkes
Copy link
Contributor

@charlieparkes
Copy link
Contributor Author

Success.
Screen Shot 2019-03-22 at 6 26 18 PM

@osterman osterman requested a review from aknysh March 23, 2019 00:14
osterman
osterman previously approved these changes Mar 23, 2019
View reviewed changes
charlieparkes
charlieparkes commented Mar 25, 2019
View reviewed changes
README.md Outdated Show resolved Hide resolved
@charlieparkes
Add volumes_from and links
3f5f3b2 
fmt

Fix typo

Update readme for volumes_from

Fix typo
@aknysh
Copy link
Member

aknysh commented Mar 29, 2019

thanks @alphachai

Looks good, but please rebuild README by executing these commands:

make init
make readme/deps
make readme

It will add the new variables to README.md and docs/terraform.md.

In general, any changes to README should be made in README.yaml, and after that executing the commands above will rebuild README.yamlintoREADME.mdand add all new variables and outputs toREADME.md`

thanks

aknysh
aknysh reviewed Mar 29, 2019
View reviewed changes
Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

@charlieparkes
Copy link
Contributor Author

@aknysh Readme & docs generated

aknysh
aknysh approved these changes Mar 29, 2019
View reviewed changes
Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @alphachai

@aknysh aknysh merged commit f670fb8 into cloudposse:master Mar 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aknysh aknysh aknysh approved these changes

@osterman osterman osterman left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@charlieparkes @aknysh @osterman