Add support for argument availability_zone_name

[auebergang]

what

• Adds support for argument availability_zone_name

why

• availability_zone_name creates the filesystem as a One Zone storage class

references

• Resource: aws_efs_file_system

[bridgecrew]

Bridgecrew has found 1 infrastructure configuration error in this PR ⬇️

[bridgecrew]

  Amazon EFS does not have an AWS Backup backup plan
    Resource: aws_efs_file_system.default | ID: BC_AWS_GENERAL_48

How to Fix

resource "aws_backup_plan" "example" {
  name = "tf_example_backup_plan"

  rule {
    rule_name         = "tf_example_backup_rule"
    target_vault_name = aws_backup_vault.test.name
    schedule          = "cron(0 12 * * ? *)"
  }

  advanced_backup_setting {
    backup_options = {
      WindowsVSS = "enabled"
    }
    resource_type = "EC2"
  }
}

resource "aws_backup_selection" "ok_backup" {
  iam_role_arn = aws_iam_role.example.arn
  name         = "tf_example_backup_selection"
  plan_id      = aws_backup_plan.example.id

  resources = [
    aws_db_instance.example.arn,
    aws_ebs_volume.example.arn,
    aws_efs_file_system.ok_efs.arn,
  ]
}

resource "aws_efs_file_system" "ok_efs" {
  creation_token = "my-product"

  tags = {
    Name = "MyProduct"
  }
}

Description

Ensure that Elastic File System (Amazon EFS) file systems are included in your backup plans for the AWS Backup.

Dependent Resources

Path	Resource	Connecting Attribute
/main.tf	aws_efs_mount_target.default	file_system_id
/main.tf	aws_efs_access_point.default	file_system_id

[Gowiem]

@auebergang can you do us a favor and add the following above line 7?

#bridgecrew:skip=BC_AWS_GENERAL_48 - Skipping as backup plan can be added via https://github.com/cloudposse/terraform-aws-backup

See here for an example: https://github.com/cloudposse/terraform-aws-alb/blob/master/main.tf#L140

[Gowiem]

/test all

[Gowiem]

@auebergang This looks good and I'm happy to get it merged, but we are hitting two issues:

1. The security issue with BridgeCrew. See the above comment inline on BC's comment.
2. Auto format is failing -- Try running the following locally:

make init
make readme
git add . 
git commit -m "chore: readme updates"
git push

[auebergang]

Updated. I've added an update to the var description as well to note providing a single subnet in the same AZ.

[nitrocode]

You'll need to add an empty commit or some commit that will update this PR so validate owners will work.

[nitrocode]

/test all

[nitrocode]

This repo is still in a pre-release until we upgrade the security group module to use 0.4.0 so this change is blocked until then unfortunately.

[nitrocode]

Thanks for your contribution! This has been released as version 0.32.0.