Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More addons #126

Closed
wants to merge 19 commits into from
Closed

More addons #126

wants to merge 19 commits into from

Conversation

nitrocode
Copy link
Member

@nitrocode nitrocode commented Aug 12, 2021

what

  • Test all recommended addons coredns, kube-proxy, and vpc-cni

why

  • It's possible additional changes may need to be made to support these addons
    We may need to add a depends_on to the eks addons resource to depend on the node group workers

references

@nitrocode
Copy link
Member Author

/test all

@nitrocode nitrocode marked this pull request as ready for review August 13, 2021 00:33
@nitrocode nitrocode requested review from a team as code owners August 13, 2021 00:33
@nitrocode nitrocode requested review from Makeshift and brcnblc August 13, 2021 00:33
@nitrocode nitrocode added patch A minor, backward compatible change bug 🐛 An issue with the system labels Aug 15, 2021
@z0rc
Copy link
Contributor

z0rc commented Aug 18, 2021

@nitrocode the code looks correct. Though I'm not sure whether I'll be using this feature. For now I prefer to have a declarative depends_on = [aws_eks_node_group.workers] in addon resource rather than waiting arbitrary time.

Also hashicorp/terraform-provider-aws#20562. Which might make waiting in tf code unnecessary, as aws provider will be able to wait by itself.

@nitrocode nitrocode closed this Nov 3, 2021
@nitrocode nitrocode deleted the more_addons branch November 3, 2021 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 An issue with the system patch A minor, backward compatible change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants