Bootstrap workers with the docker bridge #14
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See awslabs/amazon-eks-ami#183. According to AWS support, adding the default bridge support is needed in order for docker in or docker on docker to build images inside of a pod.
osterman
reviewed
May 4, 2019
|
How? This is just what Amazon had me do and it fixed my issues. I'm good with whatever works here. |
|
yes, why not put @johncblandii do you see any issues with that? |
|
I do not have a problem with that. In fact, I didn't even know it existed. I was moving quickly resolving a production Jenkins issue caused by upgrading k8s versions on a Friday night. Me on Friday when it went to the crapper: This was more of a "do this before you forget" so thx for the clarity. I can adjust our TF for this option. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See awslabs/amazon-eks-ami#183. According to AWS support, adding the default bridge support is needed in order for docker in or docker on docker to build images inside of a pod.
(moving fast, but let me know of any desired changes here and I'll adjust)