fix: sg arn output breaks when providing security groups IDs #67
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
Currently a
join()
is run over what is assumed to be all of the created security groups created by themodule.aws_security_group
. This join fails when there are no security groups being created. What's more, my reading is that only one security group will ever be created, so only one security group ID should ever need to be extracted, so this is probably a leftover from older logic.why
When using
create_security_group = false
andassociated_security_groups = [<something>]
, the module fails withThis breaks a documented supported configuration (that we happen to use and be blocked by).
references
This is just putting the fix from https://github.com/dmitrijn/terraform-aws-elasticache-memcached per the request in #56 (comment) to get this fix into main.