Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Multi-AZ option #109

Merged
merged 3 commits into from
Feb 12, 2021
Merged

Conversation

patrick-armitage
Copy link

what

  • Add option to enable Multi-AZ

why

  • Available in Terraform resource's parameters
  • Useful, the main draw for creating read replicas as an automated failover to new AZ

references

@patrick-armitage patrick-armitage requested review from a team as code owners February 10, 2021 22:34
@patrick-armitage patrick-armitage requested a review from a team as a code owner February 10, 2021 22:35
@patrick-armitage patrick-armitage requested review from jamengual and brcnblc and removed request for a team February 10, 2021 22:35
siozosdr
siozosdr previously approved these changes Feb 12, 2021
@siozosdr
Copy link

Could we get some traction in this PR? This is a standard option that should not be missing in this module.
Thanks

Gowiem
Gowiem previously approved these changes Feb 12, 2021
@Gowiem
Copy link
Member

Gowiem commented Feb 12, 2021

/test all

@Gowiem
Copy link
Member

Gowiem commented Feb 12, 2021

/rebuild-readme

@cloudpossebot cloudpossebot dismissed stale reviews from Gowiem and siozosdr via 1cbb22b February 12, 2021 15:38
@Gowiem
Copy link
Member

Gowiem commented Feb 12, 2021

/test all

@Gowiem Gowiem merged commit bfb16e4 into cloudposse:master Feb 12, 2021
@pbn4
Copy link

pbn4 commented Mar 1, 2021

Using this version results in:

Error: Unsupported argument

  on .terraform/modules/redis_broadcast/main.tf line 91, in resource "aws_elasticache_replication_group" "default":
  91:   multi_az_enabled              = var.multi_az_enabled

for me. What could be the problem?

@r4j4h
Copy link

r4j4h commented Feb 6, 2023

@pbn4 it looks like upgrading AWS provider to version 3.26.0 or later fixes this, see this comment for more details.

brian-weis-msr pushed a commit to Measurabl/terraform-aws-elasticache-redis that referenced this pull request Apr 2, 2024
Co-authored-by: cloudpossebot <11232728+cloudpossebot@users.noreply.github.com>
Co-authored-by: actions-bot <58130806+actions-bot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants