Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transit encryption enabled default to null #110

Merged
merged 5 commits into from
Feb 26, 2021
Merged

Transit encryption enabled default to null #110

merged 5 commits into from
Feb 26, 2021

Conversation

nitrocode
Copy link
Member

what

why

  • Using the default parameters I was surprised that I could not instantly connect to redis via redis-cli -h hostname -p 6379 ping
  • After some investigation, I found that the culprit was the transit_encryption_enabled parameter
  • I came across this doc which involves using stunnel to appropriately connect

references

N/A

@nitrocode nitrocode requested review from a team as code owners February 26, 2021 15:30
@nitrocode nitrocode requested a review from a team as a code owner February 26, 2021 15:30
@nitrocode nitrocode requested review from adamcrews and brcnblc and removed request for a team February 26, 2021 15:30
@nitrocode
Copy link
Member Author

/test all

jamengual
jamengual previously approved these changes Feb 26, 2021
View reviewed changes
@jamengual
Copy link
Contributor

/test all

@mergify mergify bot dismissed jamengual’s stale review February 26, 2021 19:35

This Pull Request has been updated, so we're dismissing all reviews.

@jamengual
Copy link
Contributor

/test all

@nitrocode nitrocode merged commit 96f4e48 into master Feb 26, 2021
@nitrocode nitrocode deleted the transit_encryption_enabled_false branch February 26, 2021 20:01
brian-weis-msr pushed a commit to Measurabl/terraform-aws-elasticache-redis that referenced this pull request Apr 2, 2024
@nitrocode @cloudpossebot
@jamengual @brian-weis-msr
Transit encryption enabled default to null (cloudposse#110)
57bbb3c 
* Default var.transit_encryption_enabled to false

* trans enc to true if token unless explicitly set

* Update variables.tf

* Auto Format

* Trigger validate-codeowners

Co-authored-by: cloudpossebot <11232728+cloudpossebot@users.noreply.github.com>
Co-authored-by: PePe Amengual <jose.amengual@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamengual jamengual jamengual approved these changes

@adamcrews adamcrews Awaiting requested review from adamcrews

@brcnblc brcnblc Awaiting requested review from brcnblc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nitrocode @jamengual @cloudpossebot