Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make the security group description configurable #115

Merged
merged 3 commits into from
Mar 9, 2021

Conversation

syphernl
Copy link
Contributor

@syphernl syphernl commented Mar 9, 2021

what

  • Made the security group description configurable

why

  • Since v0.35.0 a description will be set which replaces the default "Managed by Terraform". Unfortunately, a change in security group description requires it to be deleted and re-created. This is however not possible when the security group is in active use and result in a state apply failure. This variable can be used to retain the existing "Managed by Terraform" description which doesn't trigger a re-create of the security group.

references

@syphernl syphernl requested review from a team as code owners March 9, 2021 09:11
@syphernl syphernl requested review from Gowiem and brcnblc and removed request for a team March 9, 2021 09:11
@syphernl
Copy link
Contributor Author

syphernl commented Mar 9, 2021

We can either:

  • Leave the new description the new default, allowing people to override it and revert it to "Managed by Terraform" to stay compatible with existing setups
  • Use "Managed by Terraform" as default description, allowing people to override it to whatever they'd like while remaining compatible with existing setups.

For now I chose the former, since its description is more clear than the "Managed by Terraform". With one variable one can simply override this to retain the current name.

@nitrocode
Copy link
Member

/test all

variables.tf Outdated Show resolved Hide resolved
@nitrocode
Copy link
Member

/test all

@nitrocode nitrocode merged commit 8c43259 into cloudposse:master Mar 9, 2021
@syphernl syphernl deleted the fix/sg_description branch March 9, 2021 17:38
brian-weis-msr pushed a commit to Measurabl/terraform-aws-elasticache-redis that referenced this pull request Apr 2, 2024
* fix: make the security group description configurable

* Add null value in the variable description

* Auto Format

Co-authored-by: nitro <nitrocode@users.noreply.github.com>
Co-authored-by: cloudpossebot <11232728+cloudpossebot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants