Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #137 bad output when cluster_mode_enabled=true #139

Merged
merged 2 commits into from
Oct 29, 2021
Merged

Fix #137 bad output when cluster_mode_enabled=true #139

merged 2 commits into from
Oct 29, 2021

Conversation

Nuru
Copy link
Contributor

@Nuru Nuru commented Oct 29, 2021

what

why

  • join("", [null]) results in a Terraform error
  • Should have been included in v0.40.0

references

@Nuru Nuru requested review from a team as code owners October 29, 2021 02:55
@Nuru Nuru added the bugfix Change that restores intended behavior label Oct 29, 2021
@Nuru
Copy link
Contributor Author

Nuru commented Oct 29, 2021

/test all

aknysh
aknysh reviewed Oct 29, 2021
View reviewed changes
Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, a few comments

@Nuru
Copy link
Contributor Author

Nuru commented Oct 29, 2021

/test all

@Nuru Nuru merged commit 7293a0e into master Oct 29, 2021
@Nuru Nuru deleted the disabled branch October 29, 2021 03:37
brian-weis-msr pushed a commit to Measurabl/terraform-aws-elasticache-redis that referenced this pull request Apr 2, 2024
@Nuru @brian-weis-msr
Fix cloudposse#137 bad output when cluster_mode_enabled=true (cloudpo…
03508e3 
…sse#139)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nitrocode nitrocode nitrocode approved these changes

@aknysh aknysh aknysh approved these changes

@korenyoni korenyoni Awaiting requested review from korenyoni

Assignees
No one assigned
Labels
bugfix Change that restores intended behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invalid function argument in reader_endpoint_address output
3 participants
@Nuru @aknysh @nitrocode