Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small fixes - convert param values to string, set auto failover to true if cluster enabled #141

Merged
merged 5 commits into from
Dec 14, 2021
Merged

Small fixes - convert param values to string, set auto failover to true if cluster enabled #141

merged 5 commits into from
Dec 14, 2021

Conversation

nitrocode
Copy link
Member

@nitrocode nitrocode commented Dec 14, 2021 •
edited
Loading

what

  • Small fixes
  • Convert param values to string
  • Set auto failover to true if cluster enabled
  • Add descriptions to subnet and param groups

why

  • Param values will fail if they are not strings

    InvalidParameterValue: invalid parameter value, allowed values are:yes,no

  • Auto failover needs to be set to true if cluster mode is enabled or it will fail with an error

    InvalidParameterValue: Redis with cluster mode enabled cannot be created with auto failover turned off.

references

@nitrocode nitrocode added the patch A minor, backward compatible change label Dec 14, 2021
@nitrocode nitrocode requested review from a team as code owners December 14, 2021 19:46
@nitrocode nitrocode requested review from jhosteny and milldr and removed request for a team December 14, 2021 19:46
@nitrocode
Copy link
Member Author

/test all

@nitrocode nitrocode merged commit 73ba085 into master Dec 14, 2021
@nitrocode nitrocode deleted the tostring-param-values branch December 14, 2021 20:14
@syphernl syphernl mentioned this pull request Dec 15, 2021
Closed
brian-weis-msr pushed a commit to Measurabl/terraform-aws-elasticache-redis that referenced this pull request Apr 2, 2024
@nitrocode @simoferr98 @brian-weis-msr
Small fixes - convert param values to string, set auto failover to tr…
cdc0b11 
…ue if cluster enabled (cloudposse#141)

* added description on resources aws_elasticache_subnet_group and aws_elasticache_parameter_group

* Convert param values to strings

* Set auto failover to true if cluster mode enabled

* make github/init

Co-authored-by: Simone Ferraro <simone.ferraro@onsimo.it>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@korenyoni korenyoni korenyoni approved these changes

@jhosteny jhosteny Awaiting requested review from jhosteny jhosteny was automatically assigned from cloudposse/contributors

@milldr milldr Awaiting requested review from milldr milldr was automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
patch A minor, backward compatible change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nitrocode @korenyoni @simoferr98