feat: Allow configuring auth_token_update_strategy #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
These changes were released in v1.2.3. |
|
/terratest |
|
@amontalban I guess this is almost done apart from the bumping the provider version? I am also blocked by this. Thanks! |
|
@gberenice @Laakso sorry I missed your messages, I have just pushed the change for the provider version. Thanks for reviewing it! PS: If you have time I would like to merge #231 too. |
|
/terratest |
gberenice
approved these changes
Jun 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
Allow configuring
auth_token_update_strategyprovider setting.This has been added to AWS Provider on v5.27.0 in this PR hashicorp/terraform-provider-aws#16203
why
Give user the flexibility to change the update strategy when setting/changing the
auth_token.references
Closes #55