Fix: Make eks_cluster_oidc_issuer_url Non-optional and Add Validation Rule

[korenyoni]

what

• Make eks_cluster_oidc_issuer_url non-optional and add validation rule.

why

• eks_cluster_oidc_issuer_url is currently optional, except it supplies the same value directly to cloudposse/eks-iam-role/aws, which has a validation rule on it not being empty. This results in a run-time error if eks_cluster_oidc_issuer_url is empty.

╷
│ Error: Invalid value for variable
│ 
│   on .terraform/modules/ocean_controller/main.tf line 28, in module "eks_iam_role":
│   28:   eks_cluster_oidc_issuer_url = var.eks_cluster_oidc_issuer_url
│ 
│ The eks_cluster_oidc_issuer_url value must have a value.
│ 
│ This was checked by the validation rule at .terraform/modules/ocean_controller.eks_iam_role/variables.tf:38,3-13.
╵
Releasing state lock. This may take a few moments...
exit status 1

See: https://github.com/cloudposse/terraform-aws-eks-iam-role/blob/7fbf1965f71d6897ec583c30fac2875a6582a8d2/variables.tf#L34-L42

references

• Closes "Optional" eks_cluster_oidc_issuer_url Variable is Actually Required #26

[korenyoni]

/test all

[nitrocode]

Hmm the problem with this change is that now I have to provide this value even if I dont want to create an IAM role.

cc: @korenyoni