Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add permission boundary to IAM role #30

Merged
merged 4 commits into from
Jul 26, 2022

Conversation

topikachu
Copy link
Contributor

@topikachu topikachu requested review from a team as code owners July 25, 2022 11:57
@topikachu topikachu requested review from Gowiem and korenyoni July 25, 2022 11:57
@topikachu
Copy link
Contributor Author

@nitrocode Could you review this change too?
^-^

@Gowiem
Copy link
Member

Gowiem commented Jul 25, 2022

/test all

Gowiem
Gowiem previously approved these changes Jul 25, 2022
Copy link
Member

@Gowiem Gowiem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gowiem Gowiem added the terraform/0.13 Module requires Terraform 0.13 or later label Jul 25, 2022
@Gowiem
Copy link
Member

Gowiem commented Jul 25, 2022

/test all

@topikachu
Copy link
Contributor Author

@Gowiem Can somebody merge this change?
Thanks

variables.tf Outdated Show resolved Hide resolved
@Gowiem
Copy link
Member

Gowiem commented Jul 26, 2022

/test all

Copy link
Member

@Gowiem Gowiem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gowiem
Copy link
Member

Gowiem commented Jul 26, 2022

@topikachu our tests are running into the following.

TestExamplesComplete 2022-07-26T14:07:35Z logger.go:66: Running command terraform with args [apply -input=false -auto-approve -var example=Hello, world! -var attributes=["25062"] -var-file fixtures.us-east-2.tfvars -lock=false]
TestExamplesComplete 2022-07-26T14:07:37Z logger.go:66: 
TestExamplesComplete 2022-07-26T14:07:37Z logger.go:66: Error: Value for undeclared variable
TestExamplesComplete 2022-07-26T14:07:37Z logger.go:66: 
TestExamplesComplete 2022-07-26T14:07:37Z logger.go:66: A variable named "example" was assigned on the command line, but the root
TestExamplesComplete 2022-07-26T14:07:37Z logger.go:66: module does not declare a variable of that name. To use this value, add a
TestExamplesComplete 2022-07-26T14:07:37Z logger.go:66: "variable" block to the configuration.
TestExamplesComplete 2022-07-26T14:07:37Z logger.go:66: 
TestExamplesComplete 2022-07-26T14:07:37Z retry.go:80: Returning due to fatal error: FatalError{Underlying: error while running command: exit status 1; 
Error: Value for undeclared variable

@nitrocode looks like these might using some default test code... did this repo never get setup with tests? Have we been merging against this repo without that?

@nitrocode
Copy link
Member

Yes, the PR to add the tests are here #16 and are incomplete. I was blocked. If you or someone can help, that would be cool :)

@nitrocode nitrocode merged commit 8c8c090 into cloudposse:master Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
terraform/0.13 Module requires Terraform 0.13 or later
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants