Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update aws provider version #55

Merged
merged 3 commits into from
Oct 31, 2020

Conversation

tirumerla
Copy link
Contributor

what

  • Update aws provider to >= 2.0 avoid module version conflicts when used with >= 3.0 modules (eg. aws-eks-node-group).

why

  • This module is being used with terraform-aws-eks-node-group which needs aws provider version to be >= 3.0 which is causing version conflicts.

references

@tirumerla tirumerla requested a review from a team as a code owner October 31, 2020 05:58
@tirumerla tirumerla requested review from Makeshift and dotCipher and removed request for a team October 31, 2020 05:58
@tirumerla
Copy link
Contributor Author

Oops, didn't realize there was #53. Feel free to pick one and close the other.

versions.tf Outdated
@@ -2,7 +2,7 @@ terraform {
required_version = ">= 0.12.0, < 0.14.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
required_version = ">= 0.12.0, < 0.14.0"
required_version = ">= 0.12.0"

versions.tf Outdated
@@ -2,7 +2,7 @@ terraform {
required_version = ">= 0.12.0, < 0.14.0"

required_providers {
aws = "~> 2.0"
aws = ">= 2.0"
tls = "~> 2.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
tls = "~> 2.0"
tls = ">= 2.0"

versions.tf Outdated
@@ -2,7 +2,7 @@ terraform {
required_version = ">= 0.12.0, < 0.14.0"

required_providers {
aws = "~> 2.0"
aws = ">= 2.0"
tls = "~> 2.0"
local = "~> 1.3"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
local = "~> 1.3"
local = ">= 1.3"

versions.tf Outdated
@@ -2,7 +2,7 @@ terraform {
required_version = ">= 0.12.0, < 0.14.0"

required_providers {
aws = "~> 2.0"
aws = ">= 2.0"
tls = "~> 2.0"
local = "~> 1.3"
null = "~> 2.1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
null = "~> 2.1"
null = ">= 2.1"

@aknysh
Copy link
Member

aknysh commented Oct 31, 2020

/rebuild-readme

Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @tirumerla please see comments

@aknysh
Copy link
Member

aknysh commented Oct 31, 2020

/rebuild-readme

@aknysh
Copy link
Member

aknysh commented Oct 31, 2020

/test all

@aknysh aknysh merged commit 9868742 into cloudposse:master Oct 31, 2020
@tirumerla tirumerla deleted the fix-aws-version branch October 31, 2020 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants