Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch: Fix lambda role logic #18

Merged
merged 4 commits into from
Jun 8, 2022
Merged

patch: Fix lambda role logic #18

merged 4 commits into from
Jun 8, 2022

Conversation

jamengual
Copy link
Contributor

what

  • Fix logic in iam_role policy attachment.

why

  • because is fails with :
│ 
│   on .terraform/modules/sample_lambda.lambda_function/iam-role.tf line 35, in resource "aws_iam_role_policy_attachment" "vpc_access":
│   35:   count = local.enabled && try(length(var.vpc_config), 0) > 0 ? 1 : 0
│ 
│ The "count" value depends on resource attributes that cannot be determined until apply, so Terraform cannot predict how many instances will be created. To work around this, use the -target argument to first apply only the resources that the count depends on.```

@jamengual jamengual requested review from a team as code owners June 8, 2022 00:21
@mergify
Copy link

mergify bot commented Jun 8, 2022

This pull request is now in conflict. Could you fix it @jamengual? 🙏

@nitrocode
Copy link
Member

/test all

@nitrocode nitrocode added the patch A minor, backward compatible change label Jun 8, 2022
@nitrocode nitrocode merged commit 12fca4e into main Jun 8, 2022
@nitrocode nitrocode deleted the fix_lambda_role_logic branch June 8, 2022 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch A minor, backward compatible change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants