Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed CloudWatch group name #34

Closed
wants to merge 2 commits into from
Closed

Changed CloudWatch group name #34

wants to merge 2 commits into from

Conversation

salemgolemugoo
Copy link

@salemgolemugoo salemgolemugoo commented Dec 27, 2022 •
edited
Loading

what

  • CloudWatch log group name is changed

why

  • AWS Lambda stores it's logs only in CloudWatch log groups with prefix /aws/lambda/{function_name}
  • You can not override this path via terraform
  • Currently this module creates a new log group and it doesn't respect the pattern above

@salemgolemugoo salemgolemugoo requested review from a team as code owners December 27, 2022 12:53
@noqqe
Copy link

noqqe commented Feb 8, 2023

Thanks @salemgolemugoo for implementing this. Was wondering about loggroups being created and not used as well.

At least a flag to disable its creation would be great to have, but it hope this PR will get merged 👍

@Gowiem Gowiem mentioned this pull request May 18, 2023
Merged
@Gowiem Gowiem closed this in #39 May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r351574nc3 r351574nc3 Awaiting requested review from r351574nc3 r351574nc3 is a code owner automatically assigned from cloudposse/contributors

@srhopkins srhopkins Awaiting requested review from srhopkins srhopkins is a code owner automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@salemgolemugoo @noqqe @cloudpossebot