-
-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add context tags to the IAM resources #45
Conversation
/terratest |
@natemccurdy Please run the following commands, commit, and push the changes:
|
/terratest |
@natemccurdy on both PRs, you're getting this failure with the README:
That shouldn't happen because |
Prior to this, the `aws_iam_role` and the `aws_iam_policy` created by this module did not include any of the tags passed via `tags` or via `context`. This fixes that problem by specifying `tags = module.this.tags` on each of those resources so that they use the tags specified determined by the null/label context.
I do not have pre-commit installed globally. I've fixed the docs manually as per your suggestion. |
``` make init make github/init make readme ```
/terratest |
@Gowiem Great, tests are passing. What are the next steps now? Looks like we need another approval? |
@natemccurdy Yeah -- Need an org owner to approve. I've requested someone to do that in our contributor channel. Will follow up! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @natemccurdy
what
Add
tags = module.this.tags
to each of the IAM resources so that they use the tags determined by the null/labelcontext
or thetags
input.why
Prior to this, the
aws_iam_role
and theaws_iam_policy
created by this module did not include any of the tags passed viatags
or viacontext
.