Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hashicorp/template unnecessary dependency #37

Closed
wants to merge 6 commits into from

Conversation

frqnck
Copy link

@frqnck frqnck commented Oct 15, 2021

No description provided.

@frqnck frqnck requested review from a team as code owners October 15, 2021 18:25
@frqnck frqnck requested review from bradj and dylanbannon October 15, 2021 18:25
@nitrocode nitrocode added the patch A minor, backward compatible change label Oct 15, 2021
@nitrocode
Copy link
Member

Thanks for the contribution. Can we remove other providers ? I see null looks unused and random is used.

We could also bump up the aws provider to 3.x

@frqnck
Copy link
Author

frqnck commented Oct 15, 2021

Thanks for the contribution. Can we remove other providers ? I see null looks unused and random is used.

hashicorp/null can be removed.

We could also bump up the aws provider to 3.x

Both hashicorp/aws & hashicorp/random can be bumped to 3.x indeed.

@nitrocode
Copy link
Member

/test all

@akshaychopra5207
Copy link

akshaychopra5207 commented Nov 28, 2021

Can Anybody merge this PR? template provider is breaking for arm MAC M1 and also it is deprecated

@nitrocode

@nitrocode
Copy link
Member

@akshaychopra5207 we cannot merge this yet since the releases are in pre-release due to the old sg module. We need to first upgrade the sg module to latest version, then we can allow this change to go through.

@akshaychopra5207
Copy link

any expected date for that ? @nitrocode

@akshaychopra5207
Copy link

otherwise I have to create my own module as a workaround

Copy link
Member

@nitrocode nitrocode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're free to fork the code to your own module. We also accept pull requests.

See cloudposse/terraform-aws-efs#94 for references to other PRs which these can be used as a guide.

TLDR to migrate out of pre-release:

  • Deprecate old variables from before pre-release
  • Merge any outstanding tested PRs
  • Use best practices
  • Create migration guide
  • Ping us to review

cc: @Nuru

Or wait for one of the cloudposse devs to migrate this. It's on our list.

@flowinh2o
Copy link

Can this be merged yet?

@mergify mergify bot dismissed nitrocode’s stale review March 11, 2022 23:02

This Pull Request has been updated, so we're dismissing all reviews.

@Gowiem
Copy link
Member

Gowiem commented Mar 13, 2022

@flowinh2o unfortunately, this module is currently frozen as we're trying to upgrade all modules that use our security-group module to v4 and it is a time consuming process. Because our module library is so large, this takes time. We'll work on getting to this module at some point soon and will get this merged ASAP. Follow this PR for future updates.

@austin-engle
Copy link

Looks like we are out of pre-release and this might be able to be merged in? Also can we ensure that if template is removed it also gets removed from the example

@nitrocode
Copy link
Member

I believe we're still waiting on PR #41 before this PR can be mergee. Cc: @milldr and @Nuru

@Nuru Nuru closed this in #45 Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch A minor, backward compatible change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants