-
-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove hashicorp/template
unnecessary dependency
#37
Conversation
Thanks for the contribution. Can we remove other providers ? I see null looks unused and random is used. We could also bump up the aws provider to 3.x |
Both |
…aws` & `hashicorp/random`.
/test all |
Can Anybody merge this PR? template provider is breaking for arm MAC M1 and also it is deprecated |
@akshaychopra5207 we cannot merge this yet since the releases are in pre-release due to the old sg module. We need to first upgrade the sg module to latest version, then we can allow this change to go through. |
any expected date for that ? @nitrocode |
otherwise I have to create my own module as a workaround |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're free to fork the code to your own module. We also accept pull requests.
See cloudposse/terraform-aws-efs#94 for references to other PRs which these can be used as a guide.
TLDR to migrate out of pre-release:
- Deprecate old variables from before pre-release
- Merge any outstanding tested PRs
- Use best practices
- Create migration guide
- Ping us to review
cc: @Nuru
Or wait for one of the cloudposse devs to migrate this. It's on our list.
Can this be merged yet? |
This Pull Request has been updated, so we're dismissing all reviews.
@flowinh2o unfortunately, this module is currently frozen as we're trying to upgrade all modules that use our security-group module to v4 and it is a time consuming process. Because our module library is so large, this takes time. We'll work on getting to this module at some point soon and will get this merged ASAP. Follow this PR for future updates. |
Looks like we are out of pre-release and this might be able to be merged in? Also can we ensure that if template is removed it also gets removed from the example |
No description provided.