Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

context.tf & Terraform 0.14 upgrade #31

Merged
merged 5 commits into from
Dec 16, 2020
Merged

context.tf & Terraform 0.14 upgrade #31

merged 5 commits into from
Dec 16, 2020

Conversation

Nuru
Copy link
Contributor

@Nuru Nuru commented Dec 16, 2020

what

  • Upgrade to use context.tf, support Terraform 0.14, and bring up to current Cloud Posse standard

why

  • Support advanced null-label features (some work still to be done)
  • Support Terraform 0.14

notes

  • The subnets are tagged with a "Name" tag that does not conform to null-label standards. It is left for backwards compatibility.

Closes #21, closes #29, closes #30

@Nuru Nuru requested a review from a team as a code owner December 16, 2020 00:12
@Nuru Nuru requested review from 3h4x, woz5999 and maximmi and removed request for a team December 16, 2020 00:12
private.tf Outdated Show resolved Hide resolved
@woz5999 woz5999 requested a review from a team as a code owner December 16, 2020 00:18
woz5999
woz5999 previously approved these changes Dec 16, 2020
@Nuru
Copy link
Contributor Author

Nuru commented Dec 16, 2020

/test all

@Nuru
Copy link
Contributor Author

Nuru commented Dec 16, 2020

/test all

@Nuru Nuru requested a review from woz5999 December 16, 2020 00:44
@Nuru Nuru merged commit 0021c2b into master Dec 16, 2020
@Nuru Nuru deleted the terraform-0.14-upgrade branch December 16, 2020 00:45
@woz5999
Copy link
Contributor

woz5999 commented Dec 16, 2020

thanks for all the help on this @Nuru

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants