Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dual stack support #231

Merged
merged 4 commits into from
Sep 10, 2024
Merged

Dual stack support #231

merged 4 commits into from
Sep 10, 2024

Conversation

ngoyal16
Copy link
Contributor

@ngoyal16 ngoyal16 commented Sep 6, 2024

what

RDS cluster can be run in two network modes - IPV4 or DUAL.
Underlying module already supports this parameter

why

It can be mandatory to enable it to be able to connect from ipv6 only runtimes

references

Closes #175

@ngoyal16 ngoyal16 requested review from a team as code owners September 6, 2024 06:06
@mergify mergify bot added the triage Needs triage label Sep 6, 2024
@GabisCampana
Copy link

@Benbentwo

@Benbentwo
Copy link
Member

/terratest

1 similar comment
@Benbentwo
Copy link
Member

/terratest

main.tf Outdated Show resolved Hide resolved
@ngoyal16
Copy link
Contributor Author

ngoyal16 commented Sep 7, 2024

@Benbentwo issue fixed. can you please try again

@ngoyal16 ngoyal16 requested a review from Benbentwo September 7, 2024 02:24
@Benbentwo
Copy link
Member

/terratest

@Nuru
Copy link
Contributor

Nuru commented Sep 10, 2024

/terratest

Previous tests failed do to infrastructure issues

@Benbentwo Benbentwo merged commit 0f44c5a into cloudposse:main Sep 10, 2024
22 checks passed
@mergify mergify bot removed the triage Needs triage label Sep 10, 2024
Copy link

These changes were released in v1.11.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

network type parameter
4 participants