Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update outputs.tf #44

Closed
wants to merge 1 commit into from
Closed

Conversation

dhirajmishra85
Copy link

what

  • Describe high-level what changed as a result of these commits (i.e. in plain-english, what do these changes mean?)
  • Use bullet points to be concise and to the point.

why

  • Provide the justifications for the changes (e.g. business case).
  • Describe why these changes were made (e.g. why do these commits fix the problem?)
  • Use bullet points to be concise and to the point.

references

  • Link to any supporting github issues or helpful documentation to add some context (e.g. stackoverflow).
  • Use closes #123, if this PR closes a GitHub issue #123

@dhirajmishra85 dhirajmishra85 requested a review from a team as a code owner October 3, 2020 08:05
@dhirajmishra85 dhirajmishra85 requested review from jamengual and aknysh and removed request for a team October 3, 2020 08:05
@aknysh
Copy link
Member

aknysh commented Oct 3, 2020

/rebuld-readme

@aknysh
Copy link
Member

aknysh commented Oct 3, 2020

thanks @dhirajmishra85
Can you please run the following commands:

make init
make github/init
make readme

It will add new GitHub actions that we are adding to all our modules, and rebuild README

Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please see comments

@maximmi maximmi mentioned this pull request Dec 30, 2020
@maximmi maximmi closed this in #46 Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants