Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly handle enabled = false #45

Merged
merged 3 commits into from
Mar 24, 2023
Merged

Properly handle enabled = false #45

merged 3 commits into from
Mar 24, 2023

Conversation

Nuru
Copy link
Contributor

@Nuru Nuru commented Mar 23, 2023

@Nuru Nuru requested review from osterman, aknysh and nitrocode March 23, 2023 23:34
@Nuru Nuru requested review from a team as code owners March 23, 2023 23:34
@Nuru Nuru requested review from jamengual and joe-niland March 23, 2023 23:34
Copy link

@bridgecrew bridgecrew bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bridgecrew has found errors in this PR ⬇️

examples/complete/main.tf Show resolved Hide resolved
examples/complete/main.tf Show resolved Hide resolved
test/src/go.sum Show resolved Hide resolved
test/src/go.sum Show resolved Hide resolved
test/src/go.sum Show resolved Hide resolved
test/src/go.sum Show resolved Hide resolved
test/src/go.sum Show resolved Hide resolved
test/src/go.sum Show resolved Hide resolved
test/src/go.sum Show resolved Hide resolved
aknysh
aknysh previously approved these changes Mar 24, 2023
@Nuru
Copy link
Contributor Author

Nuru commented Mar 24, 2023

/test all

@Nuru
Copy link
Contributor Author

Nuru commented Mar 24, 2023

/test all

@Nuru Nuru requested a review from aknysh March 24, 2023 00:30
@Nuru Nuru added the bugfix Change that restores intended behavior label Mar 24, 2023
@Nuru Nuru merged commit aea7686 into master Mar 24, 2023
@Nuru Nuru deleted the disabled-bugfix branch March 24, 2023 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Change that restores intended behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sync_rules_and_sg_lifecycles doesn't take in account module enabled = false
2 participants