Additional TF 0.13 Fixes #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osterman
requested review from
jamengual and
aknysh
and removed request for
a team
|
/test all |
Gowiem
reviewed
Aug 19, 2020
main.tf
Outdated
| @@ -9,7 +9,7 @@ module "default_label" { | |||
| } | |||
|
|
|||
| module "notify_slack" { | |||
| source = "git::https://github.com/terraform-aws-modules/terraform-aws-notify-slack?ref=tags/v2.3.0" | |||
| source = "git::https://github.com/cloudposse/terraform-null-label.git?ref=tags/0.17.0" | |||
There was a problem hiding this comment.
@osterman Looks like something went wrong here.
There was a problem hiding this comment.
that's a wierd one! =) thanks for catching that.
There was a problem hiding this comment.
wonder if it's because it's an external module terraform-aws-modules/terraform-aws-notify-slack
jamengual
reviewed
Aug 20, 2020
|
|
||
| .PHONY : clean | ||
| ## Clean up files | ||
| clean: | ||
| rm -rf .gopath/ vendor/ $(TF_DATA_DIR) | ||
| rm -rf ../../examples/complete/*.tfstate* |
|
Hi all, is this PR currently blocked on @osterman making the changes requested by the review? |
We do not merge PR that have no tests and this is why this is failing |
* Having a go at the examples dir. * Fix the duplicate var declaration in test. * Adds context and fixes test * Add GitHub actions, and updates readme * Updates version.tf * Updates readme * Format
|
/test all |
|
/test all |
aknysh
approved these changes
Jan 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
terraform initerrors using cliwhy