Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add home directory inputs #27

Merged
merged 4 commits into from
Aug 4, 2022
Merged

Add home directory inputs #27

merged 4 commits into from
Aug 4, 2022

Conversation

nitrocode
Copy link
Member

@nitrocode nitrocode commented Jul 31, 2022 •
edited
Loading

what

  • Add optional home_directory_mappings key to sftp_users
  • Add optional s3_bucket_name key to sftp_users
  • Tag everything
  • Remove ${Transfer:*} vars

why

  • Allow overriding user assigned home directory mappings and add additional
  • Allow overriding user assigned s3 bucket
  • Fix issue where user and s3 bucket are calculated from the ${Transfer:*} vars
    • e.g. ${Transfer:UserName} would be applied but then the API would result in bob instead of this value so terraform would then try to revert the change.

references

@nitrocode nitrocode requested review from a team as code owners July 31, 2022 19:57
@nitrocode nitrocode requested review from florian0410 and woz5999 July 31, 2022 19:57
@nitrocode
Copy link
Member Author

/test all

aknysh
aknysh reviewed Jul 31, 2022
View reviewed changes
examples/vpc/outputs.tf Outdated Show resolved Hide resolved
aknysh
aknysh reviewed Jul 31, 2022
View reviewed changes
examples/complete/main.tf Outdated Show resolved Hide resolved
aknysh
aknysh reviewed Jul 31, 2022
View reviewed changes
examples/complete/main.tf Outdated Show resolved Hide resolved
aknysh
aknysh reviewed Jul 31, 2022
View reviewed changes
Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please see comments

@nitrocode
Copy link
Member Author

/test all

@nitrocode
Copy link
Member Author

/test all

@nitrocode nitrocode requested a review from aknysh July 31, 2022 23:52
milldr
milldr approved these changes Aug 4, 2022
View reviewed changes
Copy link
Member

@milldr milldr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nitrocode nitrocode merged commit 15dcc90 into master Aug 4, 2022
@nitrocode nitrocode deleted the home-directory-updates branch August 4, 2022 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Benbentwo Benbentwo Benbentwo approved these changes

@milldr milldr milldr approved these changes

@florian0410 florian0410 Awaiting requested review from florian0410 florian0410 was automatically assigned from cloudposse/contributors

@woz5999 woz5999 Awaiting requested review from woz5999 woz5999 was automatically assigned from cloudposse/contributors

@aknysh aknysh Awaiting requested review from aknysh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@nitrocode @aknysh @milldr @Benbentwo