Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VPC support and updated examples #3

Merged
merged 7 commits into from
Jul 30, 2021
Merged

VPC support and updated examples #3

merged 7 commits into from
Jul 30, 2021

Conversation

bradj
Copy link
Contributor

@bradj bradj commented Jul 30, 2021

what

  • Adds VPC support
  • SFTP users are managed via TF

why

  • Deploying into a VPC will likely be the most used configuration
  • Managing users via TF is a QoL improvement

references

https://cloudposse.atlassian.net/browse/ALTAIS-603

@bradj bradj requested review from a team as code owners July 30, 2021 18:25
@bradj bradj requested review from Gowiem and jamengual July 30, 2021 18:25
nitrocode
nitrocode reviewed Jul 30, 2021
View reviewed changes
examples/vpc/main.tf Outdated Show resolved Hide resolved
nitrocode
nitrocode reviewed Jul 30, 2021
View reviewed changes
examples/vpc/versions.tf Outdated Show resolved Hide resolved
nitrocode
nitrocode reviewed Jul 30, 2021
View reviewed changes
main.tf Show resolved Hide resolved
nitrocode
nitrocode reviewed Jul 30, 2021
View reviewed changes
main.tf Outdated Show resolved Hide resolved
nitrocode
nitrocode reviewed Jul 30, 2021
View reviewed changes
main.tf Show resolved Hide resolved
nitrocode
nitrocode reviewed Jul 30, 2021
View reviewed changes
main.tf Show resolved Hide resolved
nitrocode
nitrocode reviewed Jul 30, 2021
View reviewed changes
main.tf Show resolved Hide resolved
nitrocode
nitrocode reviewed Jul 30, 2021
View reviewed changes
variables.tf Outdated Show resolved Hide resolved
nitrocode
nitrocode reviewed Jul 30, 2021
View reviewed changes
main.tf Show resolved Hide resolved
@bradj bradj merged commit 8c0bea3 into master Jul 30, 2021
@bradj bradj deleted the feat/vpc-and-protocols branch July 30, 2021 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nitrocode nitrocode nitrocode approved these changes

@Gowiem Gowiem Awaiting requested review from Gowiem

@jamengual jamengual Awaiting requested review from jamengual

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bradj @nitrocode @cloudpossebot